mcp-server/src/core/direct-functions/move-task-cross-tag.js (2)

204-215: Error handler for TASK_ALREADY_EXISTS is now unreachable for cross-tag moves.

With the auto-renumbering behavior, cross-tag moves no longer throw TASK_ALREADY_EXISTS. This error handling block (lines 204-215) is effectively dead code for the moveTaskCrossTagDirect function.

Consider removing or updating these suggestions since the primary advice ("Choose a different target tag without conflicting IDs") no longer applies — conflicts are now resolved automatically.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@mcp-server/src/core/direct-functions/move-task-cross-tag.js` around lines 204
- 215, The TASK_ALREADY_EXISTS error branch in moveTaskCrossTagDirect is now
dead due to auto-renumbering; remove or update the branch that checks error.code
=== 'TASK_ALREADY_EXISTS' || error.message?.includes('already exists in target
tag') and stop setting errorCode = 'TASK_ALREADY_EXISTS' and the suggestions
array there; either delete the entire conditional block or replace it with a
note/suggestion reflecting that conflicts are auto-resolved (e.g., inform users
about auto-renumbering behavior), and update any callers that rely on errorCode
or suggestions from this branch accordingly.

---

120-136: Duplicated message construction may diverge from core logic.

The direct function rebuilds the success message (lines 120-130) instead of using result.message returned by moveTasksBetweenTags. The core function at scripts/modules/task-manager/move-task.js:1016-1022 already constructs an identical message with renumbering details.

Consider using result.message directly to avoid duplication and ensure consistency:

-			// Check if any tasks were renumbered during the move
-			const renumberedTasks = (result.movedTasks || []).filter(
-				(t) => t.newId !== undefined
-			);
-			let message = `Successfully moved ${sourceIds.length} task(s) from "${args.sourceTag}" to "${args.targetTag}"`;
-			if (renumberedTasks.length > 0) {
-				const renumberDetails = renumberedTasks
-					.map((t) => `${t.originalId} → ${t.newId}`)
-					.join(', ');
-				message += `. Renumbered to avoid ID collisions: ${renumberDetails}`;
-			}
-
 			return {
 				success: true,
 				data: {
 					...result,
-					message,
+					// result.message already includes renumbering details from core function
 					moveOptions,
 					sourceTag: args.sourceTag,
 					targetTag: args.targetTag
 				}
 			};

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@mcp-server/src/core/direct-functions/move-task-cross-tag.js` around lines 120
- 136, The success message is being reconstructed in move-task-cross-tag.js
instead of using the canonical message from moveTasksBetweenTags; replace the
manual message build (the renumberedTasks mapping and concatenation that sets
`message`) and instead use `result.message` returned by `moveTasksBetweenTags`
(i.e., ensure the returned payload sets data.message = result.message or spreads
result including its message) so the direct function relies on the core
`result.message` for consistency with the logic in move-task.js.

tests/integration/move-task-cross-tag.integration.test.js (1)

553-610: Consider adding test for batch collision with dependency remapping.

The current test covers a single task collision. To validate the batch dependency update logic (lines 943-985 in move-task.js), consider adding a test where:

1. Task A (id: 1) depends on Task B (id: 2)
2. Both collide with existing IDs in the target tag
3. Both get renumbered (e.g., 1→3, 2→4)
4. A's dependency is updated from 2 to 4

This would ensure the cross-reference update path is exercised.

Would you like me to generate this additional test case?

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/integration/move-task-cross-tag.integration.test.js` around lines 553 -
610, Add a new integration test for moveTasksBetweenTags that simulates a batch
collision with dependency remapping: create source tag tasks A(id:1,
dependsOn:[2]) and B(id:2) and a target tag already containing ids 1 and 2 so
both A and B must be renumbered (e.g., 1→3, 2→4); mockUtils.readJSON should
return this dataset, call moveTasksBetweenTags with both IDs, then assert
result.movedTasks contains the originalId→newId mappings for both tasks, assert
the moved task A's dependency was updated from 2 to 4 in the saved payload
(inspect mockUtils.writeJSON mock.calls[0][1]), assert the target tag now has
both original and renumbered tasks with correct ids/titles/deps and the source
tag is empty; reference moveTasksBetweenTags and the dependency remapping path
in move-task.js to locate logic to test.

scripts/modules/task-manager/move-task.js (1)

899-913: Subtask dependency string handling is unreachable for schema-validated data.

The SubtaskSchema enforces dependencies: z.array(z.number().int().positive()) — numeric only. The code at lines 903–907 checks for string dependencies with dot notation (e.g., "1.2"), which cannot appear in subtask dependency arrays that pass schema validation.

This is defensive code that won't cause problems, but it's not reachable. If validation is strictly enforced during task deserialization, consider removing this unreachable branch.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@scripts/modules/task-manager/move-task.js` around lines 899 - 913, The
string-dot dependency handling inside the taskToMove.subtasks mapping is
unreachable because SubtaskSchema enforces numeric-only dependencies; remove the
typeof dep === 'string' && dep.includes('.') branch and replace it with
numeric-only handling: inside the subtask.dependencies =
subtask.dependencies.map(...) check for typeof dep === 'number' and if dep ===
normalizedTaskId return assignedId (otherwise return dep). Update the mapping
logic around taskToMove.subtasks and variables normalizedTaskId and assignedId
accordingly and delete the unreachable string-splitting code.